Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the requirement that all bookmarks require distinct translations #607

Conversation

tfnribeiro
Copy link
Contributor

@tfnribeiro tfnribeiro commented Oct 24, 2024

Issue

In case a word has the same translation as a different word, the match exercise will expect the user to match one of the specific target boxes, which can be frustrating.

image

Fix

  • Added the requirement that for an exercise with multiple words, they need to have different translations on top of having different contexts.

In an extreme example we could have three different words with the same example:

{39129F41-668D-4EBE-B598-0CBEBF762C5A}

(This is in the dev environment, so I manually changed the 3 words to have the same translation)

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for voluble-nougat-015dd1 ready!

Name Link
🔨 Latest commit 24a8dd1
🔍 Latest deploy log https://app.netlify.com/sites/voluble-nougat-015dd1/deploys/671a4bc0e059710008f2f818
😎 Deploy Preview https://deploy-preview-607--voluble-nougat-015dd1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tfnribeiro tfnribeiro marked this pull request as ready for review October 24, 2024 13:33
Copy link
Member

@mircealungu mircealungu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea!

@mircealungu mircealungu merged commit 37e5447 into master Oct 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter words with the same translation to avoid certain situations
2 participants